New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override string trim only if needed to fix performance issue #13371

Merged
merged 1 commit into from Aug 31, 2018

Conversation

Projects
None yet
2 participants
@tsteur
Member

tsteur commented Aug 30, 2018

I had a case where this method took 90s to execute compared to builtin only a ms.

Override string trim only if needed to fix performance issue
I had a case where this method took 90s to execute compared to builtin only a ms.

@diosmosis diosmosis merged commit d43bef4 into 3.x-dev Aug 31, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details

@diosmosis diosmosis deleted the stringtrim branch Aug 31, 2018

InfinityVoid added a commit to InfinityVoid/matomo that referenced this pull request Oct 11, 2018

Override string trim only if needed to fix performance issue (matomo-…
…org#13371)

I had a case where this method took 90s to execute compared to builtin only a ms.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment