New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Matomo Tag Manager to core #13402

Merged
merged 19 commits into from Nov 9, 2018

Conversation

Projects
None yet
3 participants
@tsteur
Member

tsteur commented Sep 9, 2018

No description provided.

tsteur added some commits Sep 9, 2018

@tsteur tsteur added this to the 3.7.0 milestone Sep 12, 2018

@tsteur

This comment has been minimized.

Member

tsteur commented Sep 12, 2018

There's a failing system test in Anonymous tracking which will be fixed when merging (to avoid merging PR in submodules etc).

There are couple of failing UI tests but I believe some of them fail in 3.x-dev as well.

I've been trying to reproduce and fix this failing screenshot https://builds-artifacts.matomo.org/matomo-org/matomo/tagmanager/29950/UIIntegrationTest_admin_manage_tracking_code.png but cannot reproduce it locally when running the UI tests and neither in the browser. Also not seeing any JS error in the UI build test logs.

@tsteur

This comment has been minimized.

Member

tsteur commented Sep 12, 2018

FYI: I'm currently waiting for a review of the wording on that page.

@tsteur tsteur modified the milestones: 3.8.0, 3.7.0 Oct 31, 2018

@tsteur

This comment has been minimized.

Member

tsteur commented Oct 31, 2018

Updated wording and added translations.

@diosmosis

This comment has been minimized.

Member

diosmosis commented Nov 9, 2018

screenshots need to be updated, otherwise lgtm (tested locally and it works)

@tsteur tsteur merged commit 6c0b493 into 3.x-dev Nov 9, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@tsteur tsteur deleted the tagmanager branch Nov 9, 2018

tsteur added a commit to matomo-org/matomo-package that referenced this pull request Nov 10, 2018

Bundle Tag Manager in Matomo build
refs matomo-org/matomo#13402

Haven't tested it but I reckon it should work

@mattab mattab added the Major label Nov 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment