New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not automatically download lfs files when cloning/checking out #13449

Merged
merged 7 commits into from Sep 20, 2018

Conversation

Projects
None yet
3 participants
@diosmosis
Member

diosmosis commented Sep 18, 2018

@diosmosis diosmosis added this to the 3.6.1 milestone Sep 18, 2018

@diosmosis

This comment has been minimized.

Member

diosmosis commented Sep 18, 2018

Need to modify travis-scripts to do a git lfs pull before merging this.

@mattab

This comment has been minimized.

Member

mattab commented Sep 19, 2018

.travis.yml Outdated
@@ -86,6 +86,7 @@ before_install:
install:
- git fetch -q
- git lfs pull

This comment has been minimized.

@sgiehl

sgiehl Sep 19, 2018

Member

Any reason for adding that here globally? Wouldn't it be enough to add that to tests\travis\install_git_lfs.sh
Guess there is no use in doing that for non UI tests.

This comment has been minimized.

@diosmosis

diosmosis Sep 20, 2018

Member

Makes sense, will add it there.

This comment has been minimized.

@diosmosis

diosmosis Sep 20, 2018

Member

Updated.

diosmosis added some commits Sep 20, 2018

@sgiehl

This comment has been minimized.

Member

sgiehl commented Sep 20, 2018

UI tests are still all failing. Seems the images are not downloaded correctly. Haven't tested, but might the order of git lfs fetch, checkout and pull be wrong?

@diosmosis

This comment has been minimized.

Member

diosmosis commented Sep 20, 2018

@sgiehl build is working now

@sgiehl

sgiehl approved these changes Sep 20, 2018

@diosmosis diosmosis merged commit 038dac4 into 3.x-dev Sep 20, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/push The Travis CI build could not complete due to an error
Details

@diosmosis diosmosis deleted the lfsconfig branch Sep 20, 2018

@diosmosis

This comment has been minimized.

Member

diosmosis commented Sep 20, 2018

@mattab created simple dev-docs PR here: matomo-org/developer-documentation#265

InfinityVoid added a commit to InfinityVoid/matomo that referenced this pull request Oct 11, 2018

do not automatically download lfs files when cloning/checking out (ma…
…tomo-org#13449)

* do not automatically download lfs files when cloning/checking out

* Tweak screenshots readme.

* Add lfs pull command.

* Update submodule.

* Regenerate .travis.yml.

* Must use --exclude= in fetch/pull command.

* Update submodule to merged master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment