New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Referrer name comparison should be case insensitive … #13469

Merged
merged 2 commits into from Sep 22, 2018

Conversation

Projects
None yet
2 participants
@diosmosis
Member

diosmosis commented Sep 22, 2018

… since that is how it is stored in the log table.

Otherwise referrer name's that are not all lowercase will result in new visits being created:

  1. upper case referrer url is passed to tracker, tracker saves it as lowercase
  2. upper case referrer url is passed again, tracker compares lowercased w/ uppercased, fails
  3. tracker sets referrer keyword to host https://github.com/matomo-org/matomo/blob/3.x-dev/plugins/Referrers/Columns/Base.php#L444
  4. referrer keyword will be different than before, new visit is created

diosmosis added some commits Sep 22, 2018

@diosmosis diosmosis added this to the 3.6.1 milestone Sep 22, 2018

@tsteur

tsteur approved these changes Sep 22, 2018

@diosmosis diosmosis merged commit cf203be into 3.x-dev Sep 22, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details

@diosmosis diosmosis deleted the referrer-name-compare branch Sep 22, 2018

InfinityVoid added a commit to InfinityVoid/matomo that referenced this pull request Oct 11, 2018

Referrer name comparison should be case insensitive … (matomo-org#13469)
* Referrer name comparison should be case insensitive since that is how it is stored in the log table.

* Add test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment