New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove user-agent checking code in SessionAuth. #13470

Merged
merged 3 commits into from Sep 23, 2018

Conversation

Projects
None yet
2 participants
@diosmosis
Member

diosmosis commented Sep 22, 2018

Given the user agent can change for normal use cases like switching from mobile => desktop view on a mobile device, seems more inconvenient to have it.

@diosmosis diosmosis added this to the 3.6.1 milestone Sep 22, 2018

@tsteur

This comment has been minimized.

Member

tsteur commented Sep 22, 2018

Awesome 👍

@diosmosis

This comment has been minimized.

Member

diosmosis commented Sep 22, 2018

@tsteur does that mean this is good to merge?

@tsteur

This comment has been minimized.

Member

tsteur commented Sep 22, 2018

Haven't tested it but LGTM 👍

diosmosis added some commits Sep 23, 2018

@diosmosis diosmosis force-pushed the remove-user-agent-check branch from cb97f63 to bd707a5 Sep 23, 2018

@diosmosis diosmosis merged commit faca30f into 3.x-dev Sep 23, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@diosmosis diosmosis deleted the remove-user-agent-check branch Sep 23, 2018

InfinityVoid added a commit to InfinityVoid/matomo that referenced this pull request Oct 11, 2018

Remove user-agent checking code in SessionAuth. (matomo-org#13470)
* Remove user-agent checking code in SessionAuth.

* Fixing test.

* Fixing couple more tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment