New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't send referrer to plugin authors website #13479

Merged
merged 2 commits into from Sep 25, 2018

Conversation

Projects
None yet
4 participants
@Findus23
Member

Findus23 commented Sep 25, 2018

Followup to #12780 and related to #13204

I noticed seeing foreign Matomo domains in my reports which seems to be caused by this missing noreferrer.

@sgiehl

sgiehl approved these changes Sep 25, 2018

good catch 👍

@sgiehl sgiehl added this to the 3.6.1 milestone Sep 25, 2018

@tsteur

This comment has been minimized.

Member

tsteur commented Sep 25, 2018

👍 good find :)

@Findus23

This comment has been minimized.

Member

Findus23 commented Sep 25, 2018

Guess we should add #13204 soon or even add a Referer-Policy header to make sure the Matomo URL stays anonymous.

@diosmosis diosmosis merged commit 30492f6 into 3.x-dev Sep 25, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details

@diosmosis diosmosis deleted the noopener-plugin-author branch Sep 25, 2018

InfinityVoid added a commit to InfinityVoid/matomo that referenced this pull request Oct 11, 2018

don't send referrer to plugin authors website (matomo-org#13479)
* don't send referrer to plugin authors website

* also add noreferrer to flattr link
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment