New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix possible error in visitor profile when no visit found #13549

Merged
merged 1 commit into from Oct 30, 2018

Conversation

Projects
None yet
2 participants
@tsteur
Member

tsteur commented Oct 5, 2018

Not tested but fix this fatal error

Error: {"message":"Call to a member function getColumn() on boolean","file":"plugins/Live/VisitorProfile.php","line":86}

Happened eg on

module=API&method=Live.getVisitorProfile&idSite=1&format=JSON&token_auth=XYZANONYMIZED&visitorId=b06bc6d6274c1244&limitVisits=-1

Fix possible error in visitor profile when no visit found
Not tested but fix this fatal error
> Error: {"message":"Call to a member function getColumn() on boolean","file":"plugins\/Live\/VisitorProfile.php","line":86}

Happened eg on 
> module=API&method=Live.getVisitorProfile&idSite=1&format=JSON&token_auth=XYZANONYMIZED&visitorId=b06bc6d6274c1244&limitVisits=-1

@tsteur tsteur added the Needs Review label Oct 5, 2018

@tsteur tsteur added this to the 3.7.0 milestone Oct 5, 2018

@sgiehl

sgiehl approved these changes Oct 11, 2018

Wasn't able to reproduce the error locally. But code looks good 👍

@sgiehl sgiehl merged commit 06bf824 into 3.x-dev Oct 30, 2018

0 of 2 checks passed

continuous-integration/travis-ci/push The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details

@sgiehl sgiehl deleted the visitprofilefatalrows branch Oct 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment