New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't consider .swf files safe #13558

Merged
merged 1 commit into from Oct 10, 2018

Conversation

Projects
None yet
4 participants
@Findus23
Member

Findus23 commented Oct 8, 2018

While writing a better nginx config I noticed that swf doesn't fit in the list, as I wouldn't consider accessing random swf files safe (matomo-org/github-issues-mirror#5).

This shouldn't break anything as there is no reason for swf files in Matomo.

@tsteur

This comment has been minimized.

Member

tsteur commented Oct 8, 2018

should be fine if tests pass IMO

@mattab mattab added this to the 3.6.1 milestone Oct 9, 2018

@tsteur

tsteur approved these changes Oct 10, 2018

@sgiehl sgiehl merged commit 6e86748 into 3.x-dev Oct 10, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/push The Travis CI build could not complete due to an error
Details

@sgiehl sgiehl deleted the no-swf branch Oct 10, 2018

InfinityVoid added a commit to InfinityVoid/matomo that referenced this pull request Oct 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment