New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix domain age from archive.org #13574

Merged
merged 3 commits into from Nov 4, 2018

Conversation

Projects
None yet
3 participants
@Findus23
Member

Findus23 commented Oct 10, 2018

https://wayback.archive.org doesn't seem to exist anymore and the new website loads the content dynamically via react. But there is no need to parse the archive.org website, because they provide an API, that's perfect for this use case as it returns the closest match to a timestamp.

https://archive.org/help/wayback_api.php

@Findus23 Findus23 added this to the 3.7.0 milestone Oct 10, 2018

@tsteur

This comment has been minimized.

Member

tsteur commented Oct 10, 2018

Do you know if there is a test for this feature? For some reason I'm not seeing an expected system test file for SEO.getRank or any other test.

@Findus23

This comment has been minimized.

Member

Findus23 commented Oct 10, 2018

@tsteur This is the only test of the SEO plugin:
https://github.com/matomo-org/matomo/blob/3.x-dev/plugins/SEO/tests/Integration/SEOTest.php#L47

And only tests the rank and therefore couldn't detect this bug.

@tsteur

This comment has been minimized.

Member

tsteur commented Oct 10, 2018

Be good to add a test 👍

@Findus23

This comment has been minimized.

Member

Findus23 commented Oct 11, 2018

@tsteur Seems like I was wrong and the test tests all four values (as they are all called rank)
But because of 0e72731 it skipped when one of them fails and as the alexa rank always fails (#13427), it didn't actually test anything.

@sgiehl sgiehl merged commit e589349 into 3.x-dev Nov 4, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details

@sgiehl sgiehl deleted the fix-archive-org branch Nov 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment