New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more tests for format=original. #13584

Merged
merged 2 commits into from Nov 5, 2018

Conversation

Projects
None yet
2 participants
@diosmosis
Member

diosmosis commented Oct 11, 2018

No description provided.

@sgiehl

@diosmosis any reason for adding those tests? Imho it's very hard to validate if the content of each test file is correct. If it's only for proving the format original works, maybe there's a better way to check without comparing any file contents?

@diosmosis

This comment has been minimized.

Member

diosmosis commented Nov 4, 2018

The original format is going to be used for another plugin that will unserialize after getting serialized data back over a network. Which means it can be easy to add new data to the result of an API method that cannot be unserialized.

I suppose an alternative here is to just serialize & then unserialize it. Will look into that.

@diosmosis

This comment has been minimized.

Member

diosmosis commented Nov 5, 2018

Updated to just unserialize the response and check it unserialized.

@sgiehl

sgiehl approved these changes Nov 5, 2018

Looks much better now 👌

@sgiehl sgiehl merged commit e5fcade into 3.x-dev Nov 5, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details

@sgiehl sgiehl deleted the format-original-tests branch Nov 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment