New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let plugins modify the JS tracker #13615

Merged
merged 1 commit into from Oct 16, 2018

Conversation

Projects
None yet
2 participants
@tsteur
Member

tsteur commented Oct 15, 2018

Plugins can already modify the JS tracker by creating a tracker.js in their plugin but it is not really a supported or documented API yet. The problem with tracker.js is that this file gets added in all cases as long as the plugin that contains it is enabled. But sometimes you want to control when a certain functionality is added to tracker.js. For example you want to only add it after enabling a certain feature etc.

@tsteur tsteur added the Needs Review label Oct 15, 2018

@tsteur tsteur added this to the 3.6.1 milestone Oct 15, 2018

@diosmosis diosmosis merged commit f89ad7b into 3.x-dev Oct 16, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details

@diosmosis diosmosis deleted the custommatomojsevent branch Oct 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment