New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix punctuation, spelling, and grammar #13650

Merged
merged 1 commit into from Oct 28, 2018

Conversation

Projects
None yet
3 participants
@imronras
Contributor

imronras commented Oct 28, 2018

  • Remove and add comma
  • Add an article
  • Add hyphen
* Advanced Web Analytics capabilities such as Ecommerce Tracking, Goal tracking, Campaign tracking,
Custom Variables, Email Reports, Custom Segment Editor, Geo Location, Real time maps, and more!
* Advanced Web Analytics capabilities such as E-commerce Tracking, Goal tracking, Campaign tracking,

This comment has been minimized.

@tsteur

tsteur Oct 28, 2018

Member

FYI: I think in all docs Matomo uses "Ecommerce" over "E-commerce". Not sure why though (wanted to change it myself some time as well), the only non-hyphenated alternative should be eCommerce.

This comment has been minimized.

@tsteur

@mattab mattab merged commit d2c2ff1 into matomo-org:3.x-dev Oct 28, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@mattab

This comment has been minimized.

Member

mattab commented Oct 28, 2018

Congratulations on your first PR and contributions @imronra! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment