New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let plugins change content of JS Tracking Code Missing Email #13658

Merged
merged 1 commit into from Nov 2, 2018

Conversation

Projects
None yet
2 participants
@tsteur
Member

tsteur commented Oct 31, 2018

Through DI...

@tsteur tsteur added the Needs Review label Oct 31, 2018

@tsteur tsteur added this to the 3.7.0 milestone Oct 31, 2018

@tsteur tsteur requested a review from diosmosis Oct 31, 2018

@diosmosis

This comment has been minimized.

Member

diosmosis commented Nov 1, 2018

👍 makes sense. other option is to make Mail.send event pass $mail by reference.

@tsteur tsteur merged commit fcd604b into 3.x-dev Nov 2, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details

@tsteur tsteur deleted the jstrackingcodemissingemail branch Nov 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment