New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong Site class is used which may not be available in build #13693

merged 1 commit into from Nov 11, 2018


None yet
4 participants

tsteur commented Nov 10, 2018

@tsteur tsteur added the Needs Review label Nov 10, 2018

@tsteur tsteur added this to the 3.7.0 milestone Nov 10, 2018

@tsteur tsteur requested a review from diosmosis Nov 10, 2018

tsteur referenced this pull request Nov 10, 2018

Send email if no tracked data within N days. (#13363)
* Remember user who created a site.

* Send email if no tracked data within N days.

* Add test and get to pass.

* Fixes after manual tests of emails

* Bump version & change column name to creator_login.

* Email tweaks.

* Rename Site::getCreationUserFor

* Modify Site:: access methiod name

* Applying PR feedback.

* Move email HTML content generation logic to separate class in DI.

* tweak translations

* Apply PR review feedback.

* Couple more tweaks.

* Make tracking code check a one time task + and save timetable when removing inactive tasks.

* Update save call.

* Apply more PR feedback.

* small performance tweak and put the site name in quotes

* Fixing tests.

* Update expected file.

sgiehl approved these changes Nov 10, 2018

@diosmosis diosmosis merged commit ca95a67 into 3.x-dev Nov 11, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
continuous-integration/travis-ci/push The Travis CI build failed

@diosmosis diosmosis deleted the correctsiteclass branch Nov 11, 2018


This comment has been minimized.

Jon-IB commented Nov 11, 2018

Thanks, all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment