New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In API requests made by Insights, make sure existing query params do not affect requests. #13700

Merged
merged 2 commits into from Nov 13, 2018

Conversation

Projects
None yet
1 participant
@diosmosis
Member

diosmosis commented Nov 13, 2018

Specific issue in this case was with format=original&serialize=1, the serialize=1 was affecting the child API requests, causing them to return strings instead of DataTables. Using Request::processRequest() fixes this by itself. I also added a $default = [], because I don't think it's needed for filter params (eg) to be applied to these requests. But I'm not too familiar w/ Insights.

@diosmosis diosmosis added this to the 3.7.0 milestone Nov 13, 2018

@diosmosis diosmosis merged commit d334295 into 3.x-dev Nov 13, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@diosmosis diosmosis deleted the insights-requests branch Nov 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment