New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use current segment also in Segmented Visitorlog #13921

Merged
merged 1 commit into from Jan 22, 2019

Conversation

Projects
None yet
4 participants
@sgiehl
Copy link
Member

sgiehl commented Dec 30, 2018

this simple change should be enough so append the current (global) segment to the segment of the segmented visitor log.

fixes #13344

@sgiehl sgiehl added this to the 3.9.0 milestone Dec 30, 2018

@tsteur

This comment has been minimized.

Copy link
Member

tsteur commented Dec 30, 2018

Just tested it and works for me. By the looks Funnels and Form Analytics seems to use .show() and already set the segment by the looks so should be all fine 👍 Not sure if used anywhere else.

@diosmosis diosmosis merged commit d24e794 into 3.x-dev Jan 22, 2019

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details

@diosmosis diosmosis deleted the segmentedlogsegment branch Jan 22, 2019

@mattab mattab modified the milestones: 3.9.0, 3.8.1 Jan 22, 2019

flyapen added a commit to ICTO/matomo that referenced this pull request Jan 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment