Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readable segment values for browser, os and country segments #13929

Merged
merged 6 commits into from Apr 10, 2019

Conversation

@sgiehl
Copy link
Member

commented Jan 3, 2019

Current segments for browser, os or country are only usable using the short code (e.g. FF, IE, WIN, IOS, de, fr, ...).

refs #5309
fixes #6772
refs #14053

@@ -17,12 +18,23 @@ class BrowserName extends Base
{
protected $columnName = 'config_browser_name';
protected $columnType = 'VARCHAR(10) NULL';
protected $segmentName = 'browserCode';
protected $segmentName = 'browserName';

This comment has been minimized.

Copy link
@tsteur

tsteur Jan 3, 2019

Member

I know this PR is still WIP but be good to not break API and keep the existing segment browserCode etc. We could also make the segment accept browser names on top besides browserCode or add another segment browserName.

This comment has been minimized.

Copy link
@sgiehl

sgiehl Jan 4, 2019

Author Member

Sure. There will be two segments each browserName and browserCode and same for os.

@tsteur tsteur added this to the 3.10.0 milestone Jan 6, 2019

@sgiehl sgiehl force-pushed the segmentvalues branch from f1e5f0a to 7861151 Jan 28, 2019

@sgiehl

This comment has been minimized.

Copy link
Member Author

commented Jan 28, 2019

Expected test files may need an update before merging

@sgiehl sgiehl changed the title Readable segment values for browser and os segments Readable segment values for browser, os and country segments Feb 5, 2019

@sgiehl sgiehl force-pushed the segmentvalues branch from 7861151 to 2eeecf5 Feb 5, 2019

@sgiehl

This comment has been minimized.

Copy link
Member Author

commented Feb 5, 2019

I've updated the branch and added an additional segment for the english country name

@sgiehl sgiehl force-pushed the segmentvalues branch from 2eeecf5 to 91bd0b2 Feb 5, 2019

@mattab mattab modified the milestones: 3.11.0, 3.10.0 Mar 19, 2019

@sgiehl sgiehl force-pushed the segmentvalues branch from 91bd0b2 to f0161c1 Apr 7, 2019

@sgiehl

This comment has been minimized.

Copy link
Member Author

commented Apr 7, 2019

@diosmosis browser and os names should now be compared case insensitive

@diosmosis

This comment has been minimized.

Copy link
Member

commented Apr 7, 2019

I'm seeing this change in the tests:

-    <segment>countryCode==gb</segment>
+    <segment>countryName==gb</segment>

Is that correct? Reporting APIs may need to be changed possibly...

sgiehl added some commits Jan 3, 2019

@sgiehl sgiehl force-pushed the segmentvalues branch from f0161c1 to 0cb72b5 Apr 8, 2019

@sgiehl sgiehl force-pushed the segmentvalues branch from e3ad290 to 80d45dc Apr 9, 2019

@sgiehl

This comment has been minimized.

Copy link
Member Author

commented Apr 9, 2019

@diosmosis no, I've updated the code, so that doesn't change. Tests should also be updated now.

@diosmosis diosmosis merged commit beff637 into 3.x-dev Apr 10, 2019

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details

@diosmosis diosmosis deleted the segmentvalues branch Apr 10, 2019

@bigretromike bigretromike referenced this pull request Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.