New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When dispatch is disabled via a constant, it should not be dispatched #14034

Open
wants to merge 4 commits into
base: 3.x-dev
from

Conversation

Projects
None yet
1 participant
@tsteur
Copy link
Member

tsteur commented Jan 28, 2019

Eg when Matomo is not installed, it would still dispatch the request in https://github.com/matomo-org/matomo/blob/3.8.1-b1/plugins/Installation/Installation.php#L111 even when PIWIK_ENABLE_DISPATCH is disabled.

Will set it to WIP for now as I'm not sure if we want to have this actually merged or not.

When dispatch is disabled via a constant, it should not be dispatched
Eg when Matomo is not installed, it would still dispatch the request in https://github.com/matomo-org/matomo/blob/3.8.1-b1/plugins/Installation/Installation.php#L111 even when `PIWIK_ENABLE_DISPATCH` is disabled. 

Will set it to WIP for now as I'm not sure if we want to have this actually merged or not.

@tsteur tsteur added this to the 3.10.0 milestone Jan 28, 2019

tsteur added some commits Jan 28, 2019

@tsteur tsteur modified the milestones: 3.10.0, 3.9.0 Jan 30, 2019

@tsteur

This comment has been minimized.

Copy link
Member Author

tsteur commented Jan 30, 2019

Not sure we can easily add a test for this? Basically the idea is to throw the exception when dispatch is disabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment