Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upWhen dispatch is disabled via a constant, it should not be dispatched #14034
Conversation
tsteur
added
the
Pull Request WIP
label
Jan 28, 2019
tsteur
added this to the 3.10.0 milestone
Jan 28, 2019
tsteur
added some commits
Jan 28, 2019
tsteur
modified the milestones:
3.10.0,
3.9.0
Jan 30, 2019
tsteur
added
Needs Review
and removed
Pull Request WIP
labels
Jan 30, 2019
This comment has been minimized.
This comment has been minimized.
|
Not sure we can easily add a test for this? Basically the idea is to throw the exception when dispatch is disabled. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
tsteur commentedJan 28, 2019
Eg when Matomo is not installed, it would still dispatch the request in https://github.com/matomo-org/matomo/blob/3.8.1-b1/plugins/Installation/Installation.php#L111 even when
PIWIK_ENABLE_DISPATCHis disabled.Will set it to WIP for now as I'm not sure if we want to have this actually merged or not.