New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update _updateCommunicationEmail.twig #14037

Open
wants to merge 1 commit into
base: 3.x-dev
from

Conversation

Projects
None yet
5 participants
@AlainRnet
Copy link

AlainRnet commented Jan 28, 2019

Links in the (new?) notification email are no longer clickable.

Update _updateCommunicationEmail.twig
Links in the (new?) notification email are no longer clickable.

@sgiehl sgiehl added the Needs Review label Jan 28, 2019

@Findus23

This comment has been minimized.

Copy link
Member

Findus23 commented Jan 28, 2019

Seems to be related to #13908
@diosmosis Is there any reason (apart from the fact that most e-mail-clients make plain URLs clickable) for this?

@diosmosis

This comment has been minimized.

Copy link
Member

diosmosis commented Jan 28, 2019

No reason, the HTML can be added, though perhaps w/ the appropriate rel= in case the email client doesn't add one itself.

@@ -3,16 +3,16 @@
<p>{{ 'CoreUpdater_ThereIsNewVersionAvailableForUpdate'|translate }}</p>

<p>{{ 'CoreUpdater_YouCanUpgradeAutomaticallyOrDownloadPackage'|translate(latestVersion) }}<br/>
{{ host }}index.php?module=CoreUpdater&action=newVersionAvailable
<a href="{{ host }}index.php?module=CoreUpdater&action=newVersionAvailable">{{ host }}index.php?module=CoreUpdater&action=newVersionAvailable</a>

This comment has been minimized.

@tsteur

tsteur Jan 28, 2019

Member

the host and the other variables need some escaping?

This comment has been minimized.

@tsteur

tsteur Jan 28, 2019

Member

maybe |safelink but not sure...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment