Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two small changes for GA importer #14727

Merged
merged 4 commits into from Aug 4, 2019

Conversation

@diosmosis
Copy link
Member

commented Aug 2, 2019

  • Add Visualization.beforeRender event. I need to add a footer message after the datatable is loaded, so I can't use VIewDataTable.configure (since it's posted in the constructor).
  • Don't overwrite existing table metadata entries when loading datatables from blobs so metadata that is archived is returned through the API.
private function fireBeforeRenderHook()
{
/**
* @ignore

This comment has been minimized.

Copy link
@tsteur

tsteur Aug 3, 2019

Member

Could we make this an official event and add a small description?

@tsteur

This comment has been minimized.

Copy link
Member

commented Aug 3, 2019

LGTM... be just good to add some comment for the event

diosmosis added some commits Aug 4, 2019

@diosmosis diosmosis merged commit 8877f4a into 3.x-dev Aug 4, 2019

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@diosmosis diosmosis deleted the two-small-changes branch Aug 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.