Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some debugging info to log notifications so they can be more easily reproduced. #14753

Merged
merged 2 commits into from Aug 17, 2019

Conversation

@diosmosis
Copy link
Member

commented Aug 11, 2019

No description provided.

@diosmosis diosmosis added this to the 3.12.0 milestone Aug 11, 2019

@diosmosis

This comment has been minimized.

Copy link
Member Author

commented Aug 16, 2019

Updated.

@tsteur

This comment has been minimized.

Copy link
Member

commented Aug 16, 2019

Haven't tested it but looks good @diosmosis can you just check it escapes things before merging?

@diosmosis

This comment has been minimized.

Copy link
Member Author

commented Aug 17, 2019

Verified the notification escapes the content before displaying; adding <script>alert(1);</script> did not create an alert.

@diosmosis diosmosis merged commit 9f6197a into 3.x-dev Aug 17, 2019

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details

@diosmosis diosmosis deleted the web-notification-debug branch Aug 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.