Remove user alias from DB #15714
Merged
Remove user alias from DB #15714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsteur
added
the
Pull Request WIP
tsteur
added
Needs Review
diosmosis
reviewed
Mar 22, 2020
| @@ -1,4 +1,4 @@ | |||
| {{ postEvent("Template.beforeTopBar", userAlias, userLogin, topMenu) }} | |||
| {{ postEvent("Template.beforeTopBar", userLogin, topMenu) }} | |||
There was a problem hiding this comment.
Should we mention this change in the changelog?
There was a problem hiding this comment.
@diosmosis because they are defined in twig itself, they are not official events anyway so shouldn't be needed (see https://developer.matomo.org/api-reference/events where they aren't listed). Also checked in our code we don't seem to use them.
diosmosis
reviewed
Mar 22, 2020
plugins/ScheduledReports/tests/Integration/SubscriptionModelTest.php
Outdated
Show resolved
Hide resolved
|
Merged and created matomo-org/plugin-LoginLdap#202. ActivityLog will also need to be updated I think. |
mattab
added
the
not-in-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #13547