Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes Zend_Validate #15907

Merged
merged 1 commit into from May 8, 2020
Merged

Removes Zend_Validate #15907

merged 1 commit into from May 8, 2020

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented May 4, 2020

Zend_Validate is currently only used in Zend_Mail, which will be removed with #15891 and in Provider plugin, which will be adjusted with matomo-org/plugin-Provider#4

Once both are merged, we can finally remove Zend_Validate as well 馃帀

@sgiehl sgiehl added the Needs Review PRs that need a code review label May 4, 2020
@sgiehl sgiehl added this to the 4.0.0 milestone May 4, 2020
@Findus23
Copy link
Member

Findus23 commented May 4, 2020

Which I think only leaves us with Zend DB and Zend Sessions. I doubt the former is used (it seems to be some kind of simple ORM) and maybe we could also get rid of the latter with Matomo 4 as it was also not updated in a decade.

@sgiehl sgiehl changed the base branch from 4.x-dev to phpmailer May 8, 2020 08:11
@sgiehl
Copy link
Member Author

sgiehl commented May 8, 2020

will merge that into the phpmailer branch, as all other requirements are done.

@sgiehl sgiehl merged commit a106fc6 into phpmailer May 8, 2020
@sgiehl sgiehl deleted the removezendvalidate branch May 8, 2020 09:29
sgiehl added a commit that referenced this pull request May 14, 2020
* require composer package phpmailer/phpmailer

* change mail class to use phpmailer instead of Zend_Mail

* removes Zend_Mail and Zend_Mime

* submodule

* fix tests

* enable smtp debug for test mail command

* fix embedded images

* set language for phpmailer

* apply some review feedback

* removes Zend_Validate (#15907)

* don't inline file without cid

* submodule update

* fix test

* decouples Mail class from PHPMailer and moves sending mails to new transport layer

* submodule

* cleanup

* unset xmailer header

* simplify mail attachment handling

* adds methods to add bcc recipients

* change implementation of setReplyTo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants