Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve host validation: now using the SERVER_NAME and no longer the HOST header #16169

Merged
merged 1 commit into from Jul 5, 2020

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Jul 1, 2020

Should there be any issues coming up we might add config flags to restore old behaivour

@tsteur tsteur added the Needs Review PRs that need a code review label Jul 1, 2020
@tsteur tsteur added this to the 4.0.0 milestone Jul 1, 2020
@mattab mattab added the c: Security For issues that make Matomo more secure. Please report issues through HackerOne and not in Github. label Jul 2, 2020
@diosmosis diosmosis merged commit 57e252f into 4.x-dev Jul 5, 2020
@diosmosis diosmosis deleted the hostvalidation branch July 5, 2020 20:19
@mattab mattab changed the title Improve host validation Improve host validation: now using the SERVER_NAME and no longer the HOST header Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Security For issues that make Matomo more secure. Please report issues through HackerOne and not in Github. Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants