Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vue] fix event mapping from angularjs => vue #18622

Merged
merged 2 commits into from Jan 14, 2022

Conversation

diosmosis
Copy link
Member

Description:

A mapping is created from the vue event/property name => angularjs scope property in createAngularJsAdapter(). The mapping must be checked after converting to camelcase, but it is currently using the (potentially) unmapped name.

Review

@diosmosis diosmosis added the Needs Review PRs that need a code review label Jan 14, 2022
@diosmosis diosmosis added this to the 4.7.0 milestone Jan 14, 2022
@diosmosis diosmosis added the Bug For errors / faults / flaws / inconsistencies etc. label Jan 14, 2022
@sgiehl sgiehl merged commit dfcb170 into 4.x-dev Jan 14, 2022
@sgiehl sgiehl deleted the vue-fix-event-name-mapping branch January 14, 2022 09:31
@justinvelluppillai justinvelluppillai added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants