Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Github Action] Test 4.x branch #18679

Merged
merged 57 commits into from Jan 31, 2023
Merged

[Github Action] Test 4.x branch #18679

merged 57 commits into from Jan 31, 2023

Conversation

peterhashair
Copy link
Contributor

@peterhashair peterhashair commented Jan 23, 2022

Description:

Fork #18290
update github-action branch has some unnecessary UI updates Test 4.x branch, not sure why but seems like php8.0 MySQLi driver has a poor performance here

UI viewer test:
Because the silex is out of sup. Here is the Symfony version of it, but at the moment only tested the GitHub action part not fully tested Travis. https://github.com/matomo-org/ui-tests-viewer/pull/40

YML, PDF:
when tests failed, the system will upload the artifact as zip and stay on Github for 5 days

Once this is merged to 4.x-dev, we can use the below to wait for the other process finished. Only works on default branch

  workflow_run:
   workflows: [ Build Vue files,PHPCS check ]
   types:
     - completed

Performance

It seems like the MYSQLI is twice slower as the PDO driver, not sure why.

Review

@peterhashair peterhashair added the Needs Review For pull requests that need a code review. label Jan 24, 2022
@peterhashair peterhashair added the c: Tests & QA Improves automated tests or makes it easier to test issues. label Feb 1, 2022
@sgiehl sgiehl mentioned this pull request Feb 2, 2022
11 tasks
sgiehl

This comment was marked as outdated.

@peterhashair

This comment was marked as outdated.

@peterhashair

This comment was marked as outdated.

@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Feb 21, 2022
@peterhashair peterhashair removed the Stale The label used by the Close Stale Issues action label Feb 21, 2022
sgiehl

This comment was marked as outdated.

@peterhashair

This comment was marked as outdated.

@tsteur

This comment was marked as outdated.

@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Mar 17, 2022
@peterhashair peterhashair removed the Stale The label used by the Close Stale Issues action label Mar 17, 2022
@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Mar 24, 2022
@peterhashair peterhashair removed the Stale The label used by the Close Stale Issues action label Mar 24, 2022
@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Apr 1, 2022
@peterhashair peterhashair removed the Stale The label used by the Close Stale Issues action label Apr 1, 2022
@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Apr 9, 2022
@peterhashair peterhashair removed the Stale The label used by the Close Stale Issues action label Apr 10, 2022
@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Apr 20, 2022
sgiehl

This comment was marked as outdated.

@sgiehl sgiehl removed Needs Review For pull requests that need a code review. Stale The label used by the Close Stale Issues action labels May 5, 2022
@peterhashair

This comment was marked as outdated.

@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Jun 10, 2022
@peterhashair peterhashair removed the Stale The label used by the Close Stale Issues action label Jul 4, 2022
@peterhashair

This comment was marked as outdated.

@justinvelluppillai

This comment was marked as outdated.

@peterhashair peterhashair added the Needs Review For pull requests that need a code review. label Aug 5, 2022
@sgiehl sgiehl force-pushed the github-action-v2 branch 2 times, most recently from bf7b293 to 364eff1 Compare January 31, 2023 09:30
@sgiehl sgiehl added this to the 4.13.4 milestone Jan 31, 2023
@sgiehl
Copy link
Member

sgiehl commented Jan 31, 2023

Build finally succeeded. Even though there are still some randomly failing tests like before.

@sgiehl sgiehl added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Jan 31, 2023
@sgiehl sgiehl merged commit cd4892d into 4.x-dev Jan 31, 2023
20 of 21 checks passed
@sgiehl sgiehl deleted the github-action-v2 branch January 31, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Tests & QA Improves automated tests or makes it easier to test issues. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate from Travis CI to Github Actions to run our CI
5 participants