Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vue] migrate campaign builder directive to vue #19004

Merged
merged 11 commits into from Apr 5, 2022
Merged

[Vue] migrate campaign builder directive to vue #19004

merged 11 commits into from Apr 5, 2022

Conversation

diosmosis
Copy link
Member

Description:

Changes:

  • Migrate campaign builder directive to vue.

Review

@diosmosis diosmosis added this to the 4.9.0 milestone Mar 26, 2022
@diosmosis diosmosis marked this pull request as draft March 26, 2022 22:15
@diosmosis diosmosis added the Needs Review PRs that need a code review label Apr 3, 2022
@diosmosis diosmosis marked this pull request as ready for review April 3, 2022 14:05
peterhashair
peterhashair approved these changes Apr 4, 2022
View reviewed changes
Copy link
Contributor

@peterhashair peterhashair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@sgiehl sgiehl modified the milestones: 4.9.0, 4.10.0 Apr 4, 2022
@sgiehl sgiehl removed the Needs Review PRs that need a code review label Apr 5, 2022
@sgiehl sgiehl merged commit 1040916 into 4.x-dev Apr 5, 2022
@sgiehl sgiehl deleted the vue-campaign-build branch April 5, 2022 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterhashair peterhashair peterhashair approved these changes

@sgiehl sgiehl Awaiting requested review from sgiehl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.10.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@diosmosis @peterhashair @sgiehl