[Vue] remove angularjs from Goals plugin #19426
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…ainer for more convenient embedding of vue-entry use from within other Vue components (primarily for supporting twig Template... events in Vue).
…-org/matomo into vue-remove-angularjs-SitesManager
…o-org/matomo into vue-remove-angularjs-SegmentEditor
…tomo into vue-remove-angularjs-Goals
bx80 pushed a commit that referenced this pull request
Nov 25, 2022
* Remove use of angularjs from SitesManager plugin and add VueEntryContainer for more convenient embedding of vue-entry use from within other Vue components (primarily for supporting twig Template... events in Vue). * remove use of angularjs from SegmentEditor plugin * remove import added by phpstorm * make sure to export comparison service instance not just class * built vue files * forgot to export * built vue files * remove angularjs use from Goals plugin * built vue files * fix ui test issues * fixing some issues * fix initial value for segment definition * treat null, undefined and empty string segment value the same * Update expected screenshots * try to fix timing error in test * remove duplicate translations * remove use of unneeded html_attr escape * remove use of html_attr escape * remove unneeded use of twig html_attr escape Co-authored-by: sgiehl <email@example.com>
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.