Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vue] remove angularjs use from the DevicesDetection plugin #19435

Merged
merged 11 commits into from Jul 27, 2022
Merged

[Vue] remove angularjs use from the DevicesDetection plugin #19435

merged 11 commits into from Jul 27, 2022

Conversation

diosmosis
Copy link
Member

Description:

Changes:

  • Convert detection.twig contents to Vue component.
  • Add fixedFooter property to modalConfirm() options parameter type.

Review

@diosmosis diosmosis added this to the 5.0.0 milestone Jun 29, 2022
@diosmosis diosmosis marked this pull request as draft June 29, 2022 03:13
@diosmosis diosmosis added the Needs Review For pull requests that need a code review. label Jul 11, 2022
@diosmosis diosmosis marked this pull request as ready for review July 11, 2022 05:11
@github-actions
Copy link
Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Jul 19, 2022
@diosmosis diosmosis added the Do not close Pull requests with this label won't be marked as stale by the Close Stale Issues action label Jul 19, 2022
@github-actions github-actions bot removed the Stale The label used by the Close Stale Issues action label Jul 20, 2022
@sgiehl sgiehl merged commit 5847e51 into 5.x-dev Jul 27, 2022
1 of 4 checks passed
@sgiehl sgiehl deleted the vue-remove-angularjs-DevicesDetection branch July 27, 2022 07:41
@justinvelluppillai justinvelluppillai added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Sep 29, 2022
bx80 pushed a commit that referenced this pull request Nov 25, 2022
@diosmosis @sgiehl @bx80
[Vue] remove angularjs use from the DevicesDetection plugin (#19435)
5ce2d2d 
* remove angularjs use from the DevicesDetection plugin

* built vue files

* Allow composer plugins for dev dependency codesniffer to fix travis builds.

* update device detection demo to be accurate

* correct img width height for device detection logos

* adds missing css rule

* fix displaying device type logos

Co-authored-by: Stefan Giehl <stefan@matomo.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
Do not close Pull requests with this label won't be marked as stale by the Close Stale Issues action Needs Review For pull requests that need a code review. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@diosmosis @sgiehl @justinvelluppillai