[Vue] remove angularjs from CoreVisualizations plugin #19449
…o-org/matomo into vue-remove-angularjs-SegmentEditor
…matomo-org/matomo into vue-remove-angularjs-CoreVisualizations
bx80 pushed a commit that referenced this pull request
Nov 25, 2022
* remove use of angularjs from SegmentEditor plugin * remove import added by phpstorm * make sure to export comparison service instance not just class * built vue files * remove use of angularjs from CoreVisualizations plugin * built vue files * fixing some issues * fix initial value for segment definition * treat null, undefined and empty string segment value the same * Update expected screenshots * try to fix timing error in test * Allow composer plugins for dev dependency codesniffer to fix travis builds. * fix html attribute output for singlemetricview * remove use of html_attr escape * remove unused use statement Co-authored-by: sgiehl <email@example.com>
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.