Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vue] remove use of angularjs from API plugin #19451

Merged
merged 15 commits into from Aug 12, 2022
Merged

[Vue] remove use of angularjs from API plugin #19451

merged 15 commits into from Aug 12, 2022

Conversation

diosmosis
Copy link
Member

Description:

Changes:

  • Create Glossary vue component to get rid of ng-bind-html use.
  • remove use of angularjs directives in twig.

Review

@diosmosis diosmosis added this to the 5.0.0 milestone Jul 1, 2022
@diosmosis diosmosis marked this pull request as draft July 1, 2022 05:40
@diosmosis diosmosis added the Needs Review For pull requests that need a code review. label Jul 11, 2022
@diosmosis diosmosis marked this pull request as ready for review July 11, 2022 05:23
@github-actions
Copy link
Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Jul 19, 2022
@diosmosis diosmosis added the Do not close Pull requests with this label won't be marked as stale by the Close Stale Issues action label Jul 19, 2022
@github-actions github-actions bot removed the Stale The label used by the Close Stale Issues action label Jul 20, 2022
@github-actions
Copy link
Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions github-actions bot added Stale The label used by the Close Stale Issues action and removed Stale The label used by the Close Stale Issues action labels Jul 28, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2022

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions github-actions bot added Stale The label used by the Close Stale Issues action and removed Stale The label used by the Close Stale Issues action labels Aug 5, 2022
@sgiehl sgiehl merged commit 00b2564 into 5.x-dev Aug 12, 2022
2 of 3 checks passed
@sgiehl sgiehl deleted the vue-remove-angularjs-API branch August 12, 2022 07:30
@justinvelluppillai justinvelluppillai added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Sep 29, 2022
bx80 pushed a commit that referenced this pull request Nov 25, 2022
@diosmosis @sgiehl @bx80
[Vue] remove use of angularjs from API plugin (#19451)
3d0d71d 
* remove use of angularjs from API plugin

* remove TODO

* built vue files

* Allow composer plugins for dev dependency codesniffer to fix travis builds.

* move function to correct class

* fix order of array elements

* styling fixes

* fix styles for widgetized glossary

* update expected screenshots

* remove use of unneeded html_attr twig filter

Co-authored-by: sgiehl <stefan@matomo.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
Do not close Pull requests with this label won't be marked as stale by the Close Stale Issues action Needs Review For pull requests that need a code review. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@diosmosis @sgiehl @justinvelluppillai