New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the password length checks on invite User #19576
Conversation
update password checks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be great if we could have the acceptInvitation
method call UsersManager::checkPassword
instead of duplicating the same checks, as suggested in the issue description. There might be additional password requirements in the future, so having just one place that decides if a password is valid would be more future proof. checkPassword
throws an exception instead of providing a return value, but acceptInvitation
could catch the exception string and set it as the value of $error
.
update passcheck
simplify
update wording
update event
Description:
Fixes: #19573
update password checks
Review