Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added config option to disable archiving for actions goals #19749

Merged
merged 4 commits into from Sep 21, 2022
Merged

Added config option to disable archiving for actions goals #19749

merged 4 commits into from Sep 21, 2022

Conversation

bx80
Copy link
Contributor

@bx80 bx80 commented Sep 20, 2022

Description:

Fixes #19695

Adds a config.ini.php option disable_archive_actions_goals to disable archiving of action goal conversion data as in some cases this feature is causing archiving performance issues.

Review

@bx80 bx80 added Bug For errors / faults / flaws. Needs Review For pull requests that need a code review. labels Sep 20, 2022
@bx80 bx80 added this to the 4.12.0 milestone Sep 20, 2022
@bx80 bx80 self-assigned this Sep 20, 2022
peterhashair
peterhashair approved these changes Sep 20, 2022
View reviewed changes
Copy link
Contributor

@peterhashair peterhashair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test the config, works, and stop the goal achieved. just a tiny suggestion, not a big deal. we could use GeneralConfig::getConfigValue('disable_archive_actions_goals') function for the general config covers the case [General_1] for id site 1.

@bx80
Copy link
Contributor Author

bx80 commented Sep 20, 2022

Good spot @peterhashair, it could be particularly useful for this config setting to be set per site. 👍

@peterhashair peterhashair merged commit 8f16354 into next_release Sep 21, 2022
2 of 4 checks passed
@peterhashair peterhashair deleted the disable-archive-actions-goals branch September 21, 2022 02:55
bx80 added a commit that referenced this pull request Sep 29, 2022
@bx80
Added config option to disable archiving for actions goals (#19749)
6fff464 
* Added config option to disable archiving for actions goals

* Additionally disable entry page goals archiving if the config option is set

* Use GeneralConfig::getConfigValue to allow support for site specific config settings

* Updated UI test screenshot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterhashair peterhashair Awaiting requested review from peterhashair

Assignees

@bx80 bx80

Labels
Bug For errors / faults / flaws. Needs Review For pull requests that need a code review.
Projects
None yet
Milestone
4.12.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bx80 @peterhashair