Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP8.1 fix: we don't need to check for leaked tokens in an empty string #19756

merged 1 commit into from Sep 27, 2022


Copy link


Fixes #19753 by not trying to str_replace a null input


@justinvelluppillai justinvelluppillai added this to the 4.12.0 milestone Sep 22, 2022
@justinvelluppillai justinvelluppillai added the Needs Review For pull requests that need a code review. label Sep 22, 2022
Copy link

@peterhashair peterhashair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peterhashair peterhashair merged commit 8d15cf9 into next_release Sep 27, 2022
2 of 4 checks passed
@peterhashair peterhashair deleted the j-19753 branch September 27, 2022 01:31
@peterhashair peterhashair linked an issue Sep 27, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Needs Review For pull requests that need a code review.
None yet

Successfully merging this pull request may close these issues.

TwoFactorAuth: Deprecated - str_replace() on PHP 8.1.9
2 participants