Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure client hints are always returned as array #19855

Merged
merged 1 commit into from Oct 14, 2022
Merged

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Oct 13, 2022

Description:

client hints are expected to be an array when used in places like here:

$deviceDetector = StaticContainer::get(DeviceDetectorFactory::class)->makeInstance($this->userAgent, $this->request->getClientHints());

fixes #19849

Review

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review For pull requests that need a code review. labels Oct 13, 2022
@sgiehl sgiehl added this to the 4.12.1 milestone Oct 13, 2022
@sgiehl sgiehl requested a review from bx80 October 13, 2022 07:32
Copy link
Contributor

@bx80 bx80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review For pull requests that need a code review. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DeviceDetector Exception, $clientHints null, should be array
2 participants