Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update autocomplete on html to on and off #19873

Merged
merged 8 commits into from Nov 3, 2022
Merged

update autocomplete on html to on and off #19873

merged 8 commits into from Nov 3, 2022

Conversation

peterhashair
Copy link
Contributor

Description:

Fixes: #19872
update autocomplete on HTML from true and false to on and off

Review

update autocomplete from true and false to on and off
@peterhashair peterhashair changed the title update autocomplete on html from true and false to on and off update autocomplete on html from true and false to on and off Oct 17, 2022
@peterhashair peterhashair changed the title update autocomplete on html from true and false to on and off update autocomplete on html to on and off Oct 17, 2022
@peterhashair peterhashair added the Needs Review For pull requests that need a code review. label Oct 17, 2022
@diosmosis
Copy link
Member

diosmosis commented Oct 17, 2022

@peterhashair The change looks fine, but you don't need to request a review from me for every vue change now that the migration is nearing completion. Core reviewers can review them.

Peter added 4 commits October 18, 2022 13:27
update set-output  in buildvue
update phpcs checkout from 2 to 3
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might not work as expected in some cases. E.g. when setting autocomplete=off directly, the change here would convert this to autocomplete=on.
Additionally this will add a autocomplete=off to all input fields that don't define a autocomplete. Not sure if that is expected.

Also we should consider to use the autocomplete attribute in a way, where we not only set it to on or off, but provide which data to autofill (or not).
For now I would say we should change all occurrences of autocomplete=false to autocomplete=off, so we later have the possibility to use something like autocomplete="password"

@peterhashair peterhashair removed the Needs Review For pull requests that need a code review. label Oct 18, 2022
@peterhashair
Copy link
Contributor Author

@sgiehl that makes more sense, I guess, we can change autocomplete from boolean to string, will update all the places that appear.

Peter and others added 2 commits October 19, 2022 11:49
@peterhashair peterhashair added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review For pull requests that need a code review. labels Oct 25, 2022
@peterhashair peterhashair added this to the 4.12.3 milestone Oct 25, 2022
@justinvelluppillai justinvelluppillai modified the milestones: 4.12.3, 4.12.4 Oct 27, 2022
@peterhashair
Copy link
Contributor Author

@sgiehl any suggestion on that PR, I update autocomplete to accept string

@sgiehl sgiehl merged commit 6024bae into 4.x-dev Nov 3, 2022
@sgiehl sgiehl deleted the n19872 branch November 3, 2022 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review For pull requests that need a code review. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update autocomplete values
4 participants