Pg 820 pass segment #19890
Merged
Pg 820 pass segment #19890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Invalidated event, #PG-820
…to PG-820-pass-segment
bx80
approved these changes
Oct 21, 2022
There was a problem hiding this comment.
- Functional review done
- Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
- Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
- Security review done
- Wording review done
- Code review done
- n/a Tests were added if useful/possible
- Reviewed for breaking changes
- Updated Developer changelog updated if needed
- n/a Documentation added if needed
- n/a Existing documentation updated if needed
|
btw, this was already approved in |
bx80
pushed a commit
that referenced
this pull request
Nov 25, 2022
* Added support to pass segment in Archiving.getIdSitesToMarkArchivesAsInvalidated event, #PG-820 * Started passing dates,day and period paramters too * Started passing the name parameter too * built vue files * Updated CHANGELOG.md Co-authored-by: AltamashShaikh <AltamashShaikh@users.noreply.github.com>
bx80
pushed a commit
that referenced
this pull request
Nov 25, 2022
* Added support to pass segment in Archiving.getIdSitesToMarkArchivesAsInvalidated event, #PG-820 * Started passing dates,day and period paramters too * Started passing the name parameter too * built vue files * Updated CHANGELOG.md Co-authored-by: AltamashShaikh <AltamashShaikh@users.noreply.github.com>
sgiehl
added
the
not-in-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Please include a description of this change and which issue it fixes. If no issue exists yet please include context and what problem it solves.
Review