Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update ecommerce grid #19931

Closed
wants to merge 4 commits into from
Closed

update ecommerce grid #19931

wants to merge 4 commits into from

Conversation

peterhashair
Copy link
Contributor

@peterhashair peterhashair commented Oct 31, 2022

Description:

Fixes: #19930

  • update eCommerce to materialize grid css,
  • fixed menu for goals menu on mobile, when multiple goals it's not aligned.

Review

Peter added 2 commits October 31, 2022 16:05
update ecommerce grid
update ecommerce screenshots
@peterhashair peterhashair added the Needs Review For pull requests that need a code review. label Oct 31, 2022
Peter and others added 2 commits November 2, 2022 11:45
alien goal on mobile view, when there are mutiples
@sgiehl
Copy link
Member

sgiehl commented Nov 2, 2022

As discussed in #15349 and #19057 the ecommerce sparklines are currently using their own sparkline implementation. This needs to be fully refactored, so they are using the default sparklines.
Haven't had a look at the changes here. But we should maybe not put too much effort into fixing the UI issue if it would be magically fixed when refactoring that stuff correctly.

@sgiehl sgiehl deleted the 19930 branch April 5, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review For pull requests that need a code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WooCommerce mobile report overlapping elements
2 participants