Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates semver dependency #19934

Merged
merged 1 commit into from Nov 6, 2022
Merged

Updates semver dependency #19934

merged 1 commit into from Nov 6, 2022

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Nov 2, 2022

Description:

The version of composer/semver we are using is marked as not compatible with PHP 8.
As we are actually only using the version parsing it shouldn't be much of an issue to update the dependency to a version that support PHP 7.2. and 8.

fixes #19846

Review

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review For pull requests that need a code review. labels Nov 2, 2022
@sgiehl sgiehl added this to the 4.12.4 milestone Nov 2, 2022
Copy link
Contributor

@peterhashair peterhashair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peterhashair peterhashair merged commit 0948bb6 into 4.x-dev Nov 6, 2022
@peterhashair peterhashair deleted the semverupdate branch November 6, 2022 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review For pull requests that need a code review. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Semver dependency
2 participants