Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare github actions for Matomo 5 #19943

Merged
merged 1 commit into from Nov 7, 2022
Merged

Prepare github actions for Matomo 5 #19943

merged 1 commit into from Nov 7, 2022

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Nov 3, 2022

Description:

Before releasing Matomo 5 we will soon switch the base branch from 4.x-dev to 5.x-dev. Some of our actions are automatically running on the base branch. For this purpose we need to update the used branch for some actions.
Should be safe to already merge this, as the changes here should first be used when the base branch was changed.

But it should meanwhile already be possible to trigger the actions manually for 5.x-dev after this was merged.

Review

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review For pull requests that need a code review. labels Nov 3, 2022
@sgiehl sgiehl added this to the 5.0.0 milestone Nov 3, 2022
Copy link
Contributor

@peterhashair peterhashair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sgiehl
Copy link
Member Author

sgiehl commented Nov 7, 2022

Updating the action to use that stuff will require some more testing I guess. I would say that's out of scope for this PR, as it should only prepare some stuff for Matomo 5. We should maybe create an issue to update that stuff somewhen else.

@sgiehl sgiehl merged commit b6e00f4 into 5.x-dev Nov 7, 2022
@sgiehl sgiehl deleted the branchname branch November 7, 2022 13:33
bx80 pushed a commit that referenced this pull request Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review For pull requests that need a code review. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants