Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly escape email addresses in mailto links #19992

Merged
merged 1 commit into from Nov 14, 2022
Merged

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Nov 11, 2022

Description:

Even though this might be quit unusual, but an email address can contain certain characters that might break the mailto link.

Review

@sgiehl sgiehl added Bug For errors / faults / flaws. Needs Review For pull requests that need a code review. labels Nov 11, 2022
@sgiehl sgiehl added this to the 4.12.4 milestone Nov 11, 2022
Copy link
Contributor

@peterhashair peterhashair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failed tests unrelated.

@sgiehl sgiehl merged commit ddd8e14 into 4.x-dev Nov 14, 2022
@sgiehl sgiehl deleted the escapeemail branch November 14, 2022 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws. Needs Review For pull requests that need a code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants