Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix incorrect parameter provided to deleteInvalidations #19994

Merged
merged 1 commit into from Nov 14, 2022
Merged

fix incorrect parameter provided to deleteInvalidations #19994

merged 1 commit into from Nov 14, 2022

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Nov 11, 2022

Description:

fixes #18550

@tsteur not fully sure about the implications of this "bug". Might have caused invalidations not to be deleted.

Review

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review For pull requests that need a code review. labels Nov 11, 2022
@sgiehl sgiehl added this to the 4.12.4 milestone Nov 11, 2022
@sgiehl sgiehl requested a review from tsteur November 11, 2022 17:19
@sgiehl sgiehl merged commit 487d5f5 into 4.x-dev Nov 14, 2022
2 of 4 checks passed
@sgiehl sgiehl deleted the m18550 branch November 14, 2022 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsteur tsteur tsteur approved these changes

Assignees
No one assigned
Labels
Needs Review For pull requests that need a code review. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.12.4
Development

Successfully merging this pull request may close these issues.

Fix SQL syntax error due to incorrect parameter
2 participants
@sgiehl @tsteur