revert to reading config for superuser token_auth #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
import_logs.py --help ... --config ... Piwik will read the configuration file...to fetch the Super User token_auth A prior change had import_logs.py launching a php command on local file system to query piwik database, however piwik may not be installed on local system. And for me it didn't work. And why run a python script, to launch a php script, to query a database, to then run the http post to the (possibly remove) piwik http server.
|
the token_auth is not in the config file as of 2.1.0 (but stored in the DB) this solution is the best we could think of, even though it can seem a bit convoluted. |
|
given that the config file contains the username and password for the database, why is a token_auth not allowed there? Or is this an effort to keep server config seperate to client/end-user config? |
|
Yes an effort to keep server config in the DB as much as possible |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
import_logs.py --help ... --config ... Piwik will read the configuration file...to fetch the Super User token_auth
A prior change had import_logs.py launching a php command on local file system to query piwik database, however piwik may not be installed on local system. And for me it didn't work. And why run a python script, to launch a php script, to query a database, to then run the http post to the (possibly remove) piwik http server.