Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login flow processor #299

wants to merge 2 commits into from


Copy link

Login flow processor using to hook up into init session process as next layer of authenticate.

mattab added a commit that referenced this pull request Jun 2, 2014
Refs #299 - instead of creating loginFlow object, maybe we can throw events from the methods `processFailedSession()` and `processSuccessfullSession()`
Copy link

mattab commented Jun 2, 2014

I tried to refactor Auth class following your suggestion. But i don't really understand the naming of events you chose, in the login flow object. IMHO it would be better to put hooks in the Auth object to keep things clear, and always name hooks according to method they are triggered from.

Also let's add a comment to the hook so it shows up in the documentation here: (this page is automatically generated from the source code comments).

Let me know what you think...

@mattab mattab closed this Jun 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants