Moved attachment generation to report renderer #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattab
pushed a commit
that referenced
this pull request
Jun 9, 2014
Moved attachment generation to report renderer
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The ReportRenderer can be overridden using ScheduledReports.getRendererInstance event. This allows to render non-standard html/pdf/csv reports. If such report contains several graphs then it is not possible to send it as e-mail as the attachments are generated in ScheduledReports/API. This seems to be inconsistent. If a ReportRenderer can decide about the content of a report it should also be able to decide about the attachments.
I 've added small changes to the code which allow to override the default attachment creation process.