Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved attachment generation to report renderer #307

merged 3 commits into from Jun 9, 2014


Copy link

@mkurzeja mkurzeja commented Jun 9, 2014

The ReportRenderer can be overridden using ScheduledReports.getRendererInstance event. This allows to render non-standard html/pdf/csv reports. If such report contains several graphs then it is not possible to send it as e-mail as the attachments are generated in ScheduledReports/API. This seems to be inconsistent. If a ReportRenderer can decide about the content of a report it should also be able to decide about the attachments.

I 've added small changes to the code which allow to override the default attachment creation process.

mattab pushed a commit that referenced this pull request Jun 9, 2014
Moved attachment generation to report renderer
@mattab mattab merged commit 88abc96 into matomo-org:master Jun 9, 2014
Copy link

mattab commented Jun 9, 2014

👍 for fixing this inconsistency with a little refactoring that improves the core platform!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants