Login flow #310
Merged
Login flow #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, I like how you named the 'Login.authenticate' and 'Login.authenticate.successful' I'll merge it now, but for completion, maybe you'd like to add the 'Login.authenticate.failure' event? |
|
No problem. I'll add failure Hood. |
|
I talked too early, let's add not add un-needed events, this was bad idea ;) it's good as it is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
I added hooks and comments to them directly in Auth class. Also I changed names of these events, to be consistent with the naming convention used in this class.
As a minor change I've renamed function processSuccessfullSession. (phpstorm spellchecker has problem with this)
If you have any questions or other vision how to write this then feel free to contact me!