Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MySQL port should be always integer (HHVM compatibility) #317

merged 1 commit into from Jun 15, 2014


Copy link

@soukicz soukicz commented Jun 15, 2014

This is only the change (so far), that is needed for compatibility with HHVM.

PR solves this error message from HHVM:

Fatal error: Argument 5 to mysqli_connect() must be of type ?int, string given in /var/www/piwik/core/Tracker/Db/Mysqli.php on line 75

mattab pushed a commit that referenced this pull request Jun 15, 2014
MySQL port should be always integer (HHVM compatibility) refs #4415 

Thanks for the pull request!
@mattab mattab merged commit 0cf26d7 into matomo-org:master Jun 15, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants