Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace header() with Common::sendHeader() when possible #6211

Merged
merged 3 commits into from Sep 17, 2014

Conversation

Projects
None yet
2 participants
@kylekatarnls
Copy link
Contributor

commented Sep 14, 2014

Issue: #6184
I did this one without edit View.php because it broke some test. I will push after that.

@kylekatarnls kylekatarnls referenced this pull request Sep 14, 2014

Closed

Clean up arobases #6185

@kylekatarnls

This comment has been minimized.

Copy link
Contributor Author

commented Sep 16, 2014

I try to rebase it again.

mattab pushed a commit that referenced this pull request Sep 17, 2014

Matthieu Aubry
Merge pull request #6211 from kylekatarnls/cleanup-arobases2
Replace header() with Common::sendHeader() when possible

@mattab mattab merged commit 102dade into matomo-org:master Sep 17, 2014

1 check failed

continuous-integration/travis-ci The Travis CI build failed
Details
@mattab

This comment has been minimized.

Copy link
Member

commented Sep 17, 2014

Thanks for the pull request! it's really good to improve our general practise and we appreciate your help to get there. we hope you will keep the feedback coming 👍

@mattab mattab added the c: Platform label Sep 17, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.