Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename our test suites so the names make sense #5940 #6411

Merged
merged 24 commits into from Oct 10, 2014

Conversation

Projects
None yet
1 participant
@tsteur
Copy link
Member

tsteur commented Oct 9, 2014

tsteur added some commits Sep 25, 2014

refs #5940 put tests in correct folders, better testsuite names, some…
… tests still fail and I cannot figure out why
refs #5940 we might stay backwards compatible this way for 2 months. …
…moved some tests from unit to integration and explained when a test is a unit test, an integration test or a system test.
refs #5940 this might fix the integration tests. Took me a long time …
…to figure out what is going on. We should reset all the caches at least before each class otherwise the tests are no longer atomic and therefore worthless. This test was working when executing only this test but not when executing all tests
Merge branch 'master' into 5940_testRenamingAndCorrectFolders
Conflicts:
	tests/PHPUnit/phpunit.xml.dist
Merge branch 'master' into 5940_testRenamingAndCorrectFolders
Conflicts:
	plugins/CoreConsole/Commands/TestsRun.php
refs #5940 fix tests:run as it worked based on groups before which di…
…d not really make sense. Testsuite and groups can be combined now if wanted. By default will execute all testsuites after another
@tsteur

This comment has been minimized.

Copy link
Member Author

tsteur commented Oct 9, 2014

@sgiehl I made some changes in tests:coverage see https://github.com/piwik/piwik/blob/5940_testRenamingAndCorrectFolders/plugins/CoreConsole/Commands/CodeCoverage.php#L27 and travis.sh see https://github.com/piwik/piwik/blob/5940_testRenamingAndCorrectFolders/tests/travis/travis.sh#L70

Hope it still makes sense / works. Wasn't sure how to check. Maybe you wanna have a quick look. Can be even after merge so no hurry.

tsteur added some commits Oct 9, 2014

we will deprecate old test classes in 4 months and not in 2, simplifi…
…ed test run by only allowing short version, added some examples

tsteur added a commit that referenced this pull request Oct 10, 2014

Merge pull request #6411 from piwik/5940_testRenamingAndCorrectFolders
Rename our test suites so the names make sense #5940

@tsteur tsteur merged commit dbe6a59 into master Oct 10, 2014

1 check was pending

continuous-integration/travis-ci The Travis CI build is in progress
Details

@tsteur tsteur deleted the 5940_testRenamingAndCorrectFolders branch Oct 10, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.