New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tibet back to China map #6749

Closed
wants to merge 11 commits into
base: master
from

Conversation

Projects
None yet
7 participants
@huangzhong

huangzhong commented Nov 29, 2014

Remove commit 4e47c8 (Remove Tibet from the map) #6006

huangzhong and others added some commits Nov 28, 2014

Update visitor-map.js
Tibet is part of China.
Update AS.svg
Tibet is part of China.
Update BGD.svg
Tibet is part of China.
Update CHN.svg
Tibet is part of China.
Update world.svg
Tibet is part of China.
Jack Huang
@mattab

This comment has been minimized.

Member

mattab commented Dec 1, 2014

Hi there, thanks for the pull request. I notice it includes other commits as well. Please feel free to apply the patch to your local instance if you want to hide Tibet from the map. this is the beauty of free software that you can automatically customise it 👍

More info: #6994 (comment)

Take care

@khlipeng

This comment has been minimized.

khlipeng commented Oct 18, 2016

Tibei and Taiwan should be a part of China

@xiasun

This comment has been minimized.

xiasun commented Aug 2, 2017

I wonder when it comes to different points of view, based on which knowledge are you going to decide whether accept it or not?

For example, you accepted Tibet here as an independent country, why won't you accept California as an independent country? I want to learn about your common rule for this kind of issue.

Seriously this is important for an open source software developer.

@justjavac

This comment has been minimized.

justjavac commented Aug 2, 2017

Tibei and Taiwan should be a part of China

1 similar comment
@huruji

This comment has been minimized.

huruji commented Aug 2, 2017

Tibei and Taiwan should be a part of China

@jamesjieye

This comment has been minimized.

jamesjieye commented Aug 2, 2017

@mattab This is not cool!!! You are not acting based on common knowledge.

kinosang referenced this pull request in kinosang/piwik Aug 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment